EDM4hep Discussion

Tuesday 21 Nov 2023, 09:00 → 10:00 Europe/Zurich

Zoom

Live Notes

EDM4hep Live Notes
==================

Date: Nov 21, 2023
Indico: https://indico.cern.ch/event/1349496/

Connected: Erica, Juraj, Swathi, Tao, Juan, Leonhard, Thomas, Brieuc, Mateusz,  Frank, Andre, Sanghyun

Apologies:

## Introduction and General Points

### Upcoming workshops / conferences
https://github.com/orgs/key4hep/projects/4/views/1

## Progress and discussion

## Podio
* https://github.com/AIDASoft/podio/pulls
* https://github.com/AIDASoft/podio/issues
* https://github.com/orgs/AIDASoft/projects/2/views/1

### New tag v00-17-03

### New memory model for podio
* See also [presentation at last Key4hep meeting](https://indico.cern.ch/event/1347189/)
* https://github.com/AIDASoft/podio/pull/514

### Ensure consistency for Frames with ROOT writers
* merged https://github.com/AIDASoft/podio/pull/513
   * Now with optimized happy path :)
* merged https://github.com/key4hep/k4FWCore/pull/159
   * Fixes two related issues of `PodioOutput` crashing on inconstencies
   * https://github.com/key4hep/k4FWCore/issues/68
   * https://github.com/key4hep/k4MarlinWrapper/issues/94

### Allow to limit which collections are read
* https://github.com/AIDASoft/podio/issues/499
* https://github.com/AIDASoft/podio/pull/504
* [ ] Interface / behavior discussion

### Weird names in `dir(podio)`
* https://github.com/AIDASoft/podio/issues/512
* ROOT issue? See how this can be narrowed down.
* [ ] Still relevant after reworked python modules?

### Interface for readers / writers
* Would be nice for changing things easily at runtime without having to have multiple different readers
   * Current "low level" readers are hard to cover with an interface (different FrameDataT)
* [ ] Open issue to keep track of this

## EDM4hep
* https://github.com/key4hep/EDM4hep/pulls
* https://github.com/key4hep/EDM4hep/issues

### edm4hep::Cluster does not have a contributions vector member
* https://github.com/key4hep/EDM4hep/issues/236
* [x] close (and document)?

### Moving to double for MCParticle momentum
* Moving from `float` to `double` should be straight forward and can be done
* https://github.com/key4hep/EDM4hep/pull/237
* **Breaks in quite a few places throughout key4hep!**
   * [ ] Prepare PRs and synchronize merge
* How hard would it be keep the LCIO behavior?
   * Probably not too straight forward(?)
   * Option in writer might be easier to do than to touch generation
   * [x] Open issue on podio for discussion (https://github.com/AIDASoft/podio/issues/515)
   * **Push down the priority list**
   
### EventHeader and other related Event metadata
* https://github.com/key4hep/EDM4hep/issues/241
* Nice to have but not important enough at the moment (?)
   * As long as information is accessible, people are happy
   * Fixing this now is less work then doing it when it is used more
   * Use Frame parameters to store this information?
       * Don't have versioned information here, and it's "just another convention"
   * Make the PodioInput read the collection and put a single element into the TES?

## Converters & MarlinWrapper interplay
   
### SkipEventException not handled correctly
* https://github.com/key4hep/k4MarlinWrapper/issues/158
* Two issues in one: 
  * PodioOutput not handling things nicely (https://github.com/key4hep/k4MarlinWrapper/issues/94) 
  * MarlinWrapper not handling he exception correctly(?)
* PodioOutput ideally states which collections are missing but terminates(?)
  * Needs some work in podio and FWCore
* **For now circumvented by changing Processor**
  
### Always convert EventHeader collection
* https://github.com/key4hep/k4MarlinWrapper/pull/162
* [ ] Waiting on https://github.com/key4hep/k4FWCore/pull/161 (?)

### Missing conversion / attachment of trackeHits to tracks
* https://github.com/key4hep/k4EDM4hep2LcioConv/issues/39
* Related: https://github.com/key4hep/EDM4hep/issues/218
* Quick fix for now(?): Convert `TrackerHitPlane` to `edm4hep::TrackerHit` using the `TrackerHit` interface from LCIO
   * https://github.com/tmadlener/k4EDM4hep2LcioConv/commit/3970209c0c243969180be15aebe7fe05f83de45c
   * Uncertainties in U/V still to be handled
* [ ] Revive https://github.com/AIDASoft/podio/pull/215

## AoB

  
## Next meeting:
* Dec 05, 09:00

09:00 → 09:05 Introduction

Speakers: Andre Sailer (CERN), Frank-Dieter Gaede (Deutsches Elektronen-Synchrotron (DE)), Thomas Madlener (Deutsches Elektronen-Synchrotron (DESY))

EDM4hep Github

Podio Github

09:45 → 09:46 Discussion

Speaker: Dr All