In the first part of this talk I review the constraints imposed on supersymmetric models by the electron, neutron, and mercury EDMs as well as possible ways to avoid overproduction of EDMs. In the second half I consider heterotic string models in which CP is broken spontaneously and discuss how these models confront the EDM constraints.