EDM4hep Discussion

Europe/Zurich
Vidyo

Vidyo

EDM4hep Live Notes
==================

Date: July 7, 2020
Indico: https://indico.cern.ch/event/936567/

This is a document for taking notes during EDM4hep meetings.

Connected: Jiaheng, Placido, Tao, Weidong, Andre, Benedikt, Valentin, Graeme, Thomas, Gerri, Sang Hyon, Clement, Huhao

Apologies:

## Introduction and General Points


Almost 1 year anniversary of the EDM4hep Meetings!


## Progress and Discussion

###

Technical discussion: July 3: https://indico.cern.ch/event/936095/
* List of issues: https://github.com/AIDASoft/podio/issues/109
* Follow up
    * Trying to disable copy c'tor for collections, to fail at compile time. Upsets ROOT-IO.
    * Cleaning up python generator, also maybe improving c++ templates

### Delphes plugin

* PR Ready for review
    * https://github.com/key4hep/EDM4hep/pull/56
    * No longer depends on these changes to podio
        * (Optional) Non-const getter: https://github.com/AIDASoft/podio/pull/95
            * Using `registerCollection` instead
        * (Optional) Make mass member: https://github.com/key4hep/EDM4hep/pull/69
    * Added tests for RecoParticleRef
   
* Delphes2lcio: https://github.com/iLCSoft/LCIO/pull/80


### Spack installation

### Nightly Builds and CI

## Podio

### "event class" in podio

* or possibility to add collection after initialisation?
    * Link: https://github.com/AIDASoft/podio/issues/112

### Non-const getter

* https://github.com/AIDASoft/podio/pull/95
* Need to understand use cases and desired behaviour from podio
* Alternative is using a `const_cast` as in dd4hep output
    * is `registerCollection` the solution?
        * Seems to be

### Meta Data

#### Usage of "metadata" for user defined data


#### Metadata handling in CMS to be summarised by Benedikt

### Issues following MetaData Developments

* cannot write out event data previously read from file
    * Issue: https://github.com/AIDASoft/podio/issues/103
    * Test: https://github.com/AIDASoft/podio/pull/102

#### Writing second file with another tree

* Have to do: ``` TFile::Open("tmp.root", "RECREATE")``` ?
    * Doesn't help
    * Would help to see the code

### EventStore

- Needs some reworking and definition of interfaces

### Schema Evolution

- Version for object descriptions, etc.
- Open issue: https://github.com/AIDASoft/podio/issues/86

### Features

* Subset collections?

## LCIOConverters

* Used to reconstruct clusters with Pandora
    * Publish Pandora Interface on github


## EDM4hep

### Release 1.0

* Need:
    * ~~Plugin~~
    * ~~Eventheader~~
    * ~~Meta Data (Event / Run Parameters)~~

### Units convention?
* What's the default units?
    * Comments in the data model, same as LCIO
        * mm and GeV and (angles)
* Should we have several utilities to convert the units from Geant4, DD4hep, ROOT to EDM4hep?
    * Geant4, Root, DD4hep can (should) use the same units from newest(?) versions (MeV and mm)
        * Check edm4hep output from dd4hep
        * https://github.com/key4hep/EDM4hep/blob/8078d059b2a14da571ddc29fd6baf52de045420e/plugins/DDG4EDM4hep/edm4hep/Geant4Output2EDM4hep.cpp#L445
    * Probably don't need additional conversion?

### Reconstructed Particle: Mass dependent on energy?
* https://github.com/key4hep/EDM4hep/pull/69
* See explanations in PR
* Keep separate members, but also allow consistent setting?
* Add utility to return 4-vector from Reconstructed Particle
    * Ignore the mass?
* Clarify consistency responsibility to user?
* Need more time to think about this

## AOB

### Conditions handling in Belle2
* Benedikt, or Martin Ritter


### Dual Readout Calorimeter Plans
* First implement DD4hep description
* Look at use of EDM4hep for simulation, different data model in use at the moment

### Next meeting:

* July 21, 2020

 

 

There are minutes attached to this event. Show them.
    • 09:00 09:05
      Introduction 5m
      Speakers: Andre Sailer (CERN), Frank-Dieter Gaede (Deutsches Elektronen-Synchrotron (DE))
    • 09:55 10:00
      Discussion 5m
      Speaker: Dr All